Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard chemistry lab electrolysis #36822

Merged
merged 5 commits into from Jan 10, 2020
Merged

Onboard chemistry lab electrolysis #36822

merged 5 commits into from Jan 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 8, 2020

Summary

SUMMARY: Features "adds pseudo electrolysis_kit to chemlab"

Purpose of change

There is virtually no difference between having an onboard chemistry lab with a pot inside and a kitchen unit with a chemistry set, which basically makes an onboard chemistry lab a flavor item. This should not be the case.

Describe the solution

add electrolysis_kit to chemlab pseudoitems, recipes and parts breakdown list

Testing

Seems to work as intended.

Additional context

Chemlab still deserves more love, but at least it has a practical reason for existence now (other than being meth van flavor item).

@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 8, 2020

You could give the onboard chemistry lab an analytical suite as well

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Vehicles Vehicles, parts, mechanics & interactions labels Jan 8, 2020
@ghost
Copy link
Author

ghost commented Jan 8, 2020

You could give the onboard chemistry lab an analytical suite as well

Hmm, considering its present applications still a marginal improvement - it is only used for mutagens IIRC.
But I can see chemlab equipped will all specialized qualities sans concentration (microcentrifuge/rot-evap), so analysis, fine distillation, separation, thermometer and distill 2 (still has distill 2, kinda backwards if you ask me, unless crafting speed would scale with tool quality) qualities included. Probably even introducing some new ones eg. vacuum pump for reduced pressure distillation.

@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 8, 2020

I think concentration, distillation 2, and fine distillation are difficult to imagine in a mobile cabinet too easily. Arguably separation too, but the funnel isn't too hard to store. The others require pretty large delicate setups.

Although these tools aren't used widely yet, they can and should be. Having them more available is a place to start.

@Ker-Nes
Copy link
Contributor

Ker-Nes commented Jan 8, 2020

fine distillation

Fine distillation in the game is just a matter of the proper glassware, and nothing that complicated either. Just something like this. It might not right for the vehicle chem station itself, but we should definitely be able to make it from glass like other glass stuff, if probably requiring a higher skill level than a simple jar.

@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 8, 2020

I added fine distillation, I know. It should be possible to make a fractional still, but nobody has done so yet.

@ghost
Copy link
Author

ghost commented Jan 8, 2020

Truly, most of those qualities are contrived. It's nice to have ground joint glassware, but eg. both basic distillation and reflux could be done with some sort of makeshift retort from a glass bottle, piece of bent copper piping secured with some clay and piercing perhaps large plastic bottle filled with cold water, with obvious caveats of working on small scale, under atmospheric pressure and with at most moderately corrosive compounds. Advancing this to fractional (fine distill I suppose) distillation would be a matter of sticking a thermometer in and packing main bottle's neck with eg. copper wool/shavings.

@ghost
Copy link
Author

ghost commented Jan 8, 2020

I added fine distillation, I know. It should be possible to make a fractional still, but nobody has done so yet.

Sill is pretty much required to be able to fraction, unless you enjoy methanol in your moonshine.

Initially I thought that distill 2 would mean fractioning but then chemistry set should be perfectly capable of that as well, but eventually introduction of fine distill confused me out of those deliberations and attempting to devise workable solution.

Frankly it would make most sense if qualities were able to influence crafting times.

@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 8, 2020

A fractional still is different from a large scale still because it's designed to have fine control over the fractionation rate. That's why fractionation columns were invented. I have no objection to someone devising some new things that have it as a tool quality, and some recipes to make them. They're not uncraftable IRL.

It would all make more sense if qualities could affect crafting time, yes, but basically distillation 2 is bulk_distill while fine distillation is for precision chemistry.

@ghost
Copy link
Author

ghost commented Jan 8, 2020

Well, with the stipulation that 'one day distill 2 will be faster/scale better than 1' it does make sense.

@kevingranade kevingranade merged commit 397d11e into CleverRaven:master Jan 10, 2020
fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this pull request Jan 10, 2020
Onboard chemistry lab electrolysis (CleverRaven#36822)
va5h added a commit to va5h/Cataclysm-DDA that referenced this pull request Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants