Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates fire extinguisher volumes to match container volumes #36855

Merged

Conversation

Brian-Otten
Copy link
Contributor

@Brian-Otten Brian-Otten commented Jan 9, 2020

I slightly increased weight and charges of the large extinguisher to match new volume.

Summary

SUMMARY: Balance "Fire extinguisher volume matches container volume'"

Purpose of change

Fixes #36603
Fire extinguisher volume does not match their container volume

Describe the solution

Volume of the fire extinguishers was increased. The small fire extinguisher was close to correct, so only had it's volume slightly adjusted. The large fire extinguisher now has five gallons of foam in flavor text, weighs about what the heavier fire extinguishers weigh in real life, and has 40 extra charges.

Describe alternatives you've considered

Adding new empty water containers with the volumes of the previous fire extinguishers. Keeping the old values and making fire extinguishers disassemble into scrap metal instead.

Testing

Spawned in both fire extinguishers, checked that they had the correct weights, volume, and charges. then put out some fires with them.

Als slightly increases weight and charges of the large extinguisher to match new volume.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extinguishers are smaller than the containers they produce when dissassembled.
2 participants