Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only list tilesets once #36896

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Only list tilesets once #36896

merged 2 commits into from
Jan 10, 2020

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Jan 10, 2020

Summary

SUMMARY: Bugfixes "Only list tilesets once"

Purpose of change

Fixes #36617

Describe the solution

When building tileset list check if the the tileset is already in the list before adding it.

Describe alternatives you've considered

Testing

image

Additional context

There might be a better way to compare two vector

@I-am-Erk I-am-Erk added <Bugfix> This is a fix for a bug (or closes open issue) Controls / Input Keyboard, mouse, keybindings, input UI, etc. [C++] Changes (can be) made in C++. Previously named `Code` labels Jan 10, 2020
src/options.cpp Outdated Show resolved Hide resolved
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
@kevingranade kevingranade merged commit 412bbee into CleverRaven:master Jan 10, 2020
@Fris0uman Fris0uman deleted the gfx branch January 10, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Controls / Input Keyboard, mouse, keybindings, input UI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tilesets listed twice in the options menu
4 participants