Fix loading submap radiation. #36903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check bounds before setting the value.
ZhilkinSerg
added
<Bugfix>
| if( rad_cell < SEEX * SEEY ) { | ||
| set_radiation( { 0 % SEEX, rad_cell / SEEX }, rad_strength ); | ||
| rad_cell++; | ||
| } |
There was a problem hiding this comment.
I think the old code that used an "array trick" was also transposing the radiation map every time the game is saved and loaded. This fixes that too.
|
I wonder how the game managed to create a save file that triggers this. |
Never mind. Figured it out. UBSan just didn't like the "array trick". |
|
According to c faq UBSan might technically be right to flag this as UB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: NoneFixes #36811.
Fix deserialization of submap radiation:
Check bounds before setting the value.
Edit: removed lots of useless changes.