Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix unloading ammo belts on map"
Purpose of change
Fixes #35368
Describe the solution
When pressing
U
it brings up a menu to allow you to unload items from your inventory and from the map. the unload function itself assumes that the items are in your inventory, and constructs an item_location from theplayer
object. This leads to an error with the visitable interface, since the item isn't owned by what it thinks it is. A more thorough fix is to refactor the wholeunload
funciton into 3 or more functions that do separate things, since at least one of the things the current unload function does is to open a prompt.The actual fix is to call item_location::obtain() in avatar_action::unload() which is the function that opens the inventory prompt and allows you to pick items that are not in your inventory.
Testing
spawn an ammo belt, drop it next to me, and then press
U
to unload it.