Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain the difference between tiles and curses on release page #37433

Merged
merged 5 commits into from
Jan 30, 2020
Merged

Explain the difference between tiles and curses on release page #37433

merged 5 commits into from
Jan 30, 2020

Conversation

snipercup
Copy link
Contributor

@snipercup snipercup commented Jan 27, 2020

Summary

SUMMARY: Content "Explain the difference between tiles and curses in releases page"

Purpose of change

Fixes #37430

Describe the solution

Adds an explanation of the difference between tiles and curses release

Describe alternatives you've considered

Not changing the page, include the text under a different header

Testing

The text on the page loads fine but the dynamic content is not loaded. I'm not sure if it should load in the preview on github or if it only works when deployed?

@snipercup snipercup changed the title Explain the difference between tiles and curses Explain the difference between tiles and curses on release page Jan 27, 2020
@snipercup snipercup marked this pull request as ready for review January 27, 2020 10:09
@ZhilkinSerg ZhilkinSerg added Organization: Sites Issues concerning web-sites that relate to Cataclysm [Markdown] Markdown issues and PRs labels Jan 27, 2020
releases.md Outdated Show resolved Hide resolved
Co-Authored-By: Alexey Mostovoy <1931904+AMurkin@users.noreply.github.com>
@Jovus
Copy link
Contributor

Jovus commented Jan 28, 2020

Note: downloads with 'Curses' in the name include a version that can be played in console and has no graphics. Downloads with 'Tiles' in the name includes a version of the game that has graphics.

I'd change this slightly, to read something like:

Note: downloads with 'Curses' in the name include a version that can be played in console and has purely text-based display. Downloads with 'Tiles' in the name includes a version of the game that has sprite-based graphics.

It's a pedantic point, but I could see someone becoming confused and thinking curses meant something like adventure games, or tiles implies something greater than it is.

releases.md Outdated Show resolved Hide resolved
@snipercup
Copy link
Contributor Author

Thanks, I've committed your suggestion

@I-am-Erk I-am-Erk merged commit 2608758 into CleverRaven:gh-pages Jan 30, 2020
@snipercup snipercup deleted the Explain-the-difference-between-tiles-and-curses branch January 31, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Markdown] Markdown issues and PRs Organization: Sites Issues concerning web-sites that relate to Cataclysm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants