Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plural names in the Generic Guns mod #37514

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Fix plural names in the Generic Guns mod #37514

merged 1 commit into from
Jan 29, 2020

Conversation

AMurkin
Copy link
Contributor

@AMurkin AMurkin commented Jan 29, 2020 •
edited
Loading

Summary

Summary: None

Purpose of change

Fix plural names

Describe the solution

Replace "name-plural" with "name_plural"
Use the new name objects.

Testing

Strings are extracted and pot updated fine.

@ymber
Copy link
Member

ymber commented Jan 29, 2020

name_plural is a legacy member. These should use the new name objects.

@AMurkin AMurkin force-pushed the fix-mod-gg-plural-names branch from 2dea152 to e53f0fc Compare January 29, 2020 17:18
@AMurkin
Copy link
Contributor Author

AMurkin commented Jan 29, 2020

name_plural is a legacy member. These should use the new name objects.

You're right.

@esotericist esotericist added [JSON] Changes (can be) made in JSON Mods: Generic Guns Anything to do with Generic Guns Translation I18n labels Jan 29, 2020
@ZhilkinSerg ZhilkinSerg merged commit 7c62c5a into CleverRaven:master Jan 29, 2020
@AMurkin AMurkin deleted the fix-mod-gg-plural-names branch January 29, 2020 18:55
@weekly-digest weekly-digest bot mentioned this pull request Feb 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[JSON] Changes (can be) made in JSON Mods: Generic Guns Anything to do with Generic Guns Translation I18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AMurkin @ymber @esotericist @ZhilkinSerg