Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arithmetical error on load #37518

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Fix arithmetical error on load #37518

merged 1 commit into from
Jan 29, 2020

Conversation

AMurkin
Copy link
Contributor

@AMurkin AMurkin commented Jan 29, 2020

Summary

SUMMARY: None

Purpose of change

Fixes #37516

Describe the solution

Check if skill_rate * char_rate <= 0 before calculating delta % ( skill_rate * char_rate ).

Testing

No crash with the same values.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics labels Jan 29, 2020
@ZhilkinSerg ZhilkinSerg merged commit e973f5f into CleverRaven:master Jan 29, 2020
@ifreund ifreund mentioned this pull request Jan 29, 2020
Closed
@AMurkin AMurkin deleted the fix-rust-arithmetical-error branch January 29, 2020 18:47
@weekly-digest weekly-digest bot mentioned this pull request Feb 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Arithmetical error" leading to crash
2 participants
@AMurkin @ZhilkinSerg