Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete survivor helmets #37524

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Obsolete survivor helmets #37524

merged 1 commit into from
Jan 29, 2020

Conversation

ymber
Copy link
Member

@ymber ymber commented Jan 29, 2020

Summary

SUMMARY: Content "Obsolete survivor helmets"

Purpose of change

Easy target to start reworking survivor armor at. Adding bits of leather and metal to a helmet isn't going to get you anything better than a standard combat helmet and a hood. You can't resize a kevlar helmet. There's not really any reason for these to exist.

Describe the solution

Obsolete survivor helmets.

Testing

Game loads correctly.

@ymber ymber added the Items / Item Actions / Item Qualities Items and how they work and interact label Jan 29, 2020
@ZhilkinSerg ZhilkinSerg added the [JSON] Changes (can be) made in JSON label Jan 29, 2020
@ZhilkinSerg ZhilkinSerg merged commit e26f2ea into CleverRaven:master Jan 29, 2020
@Brian-Otten
Copy link
Contributor

I'm pretty sure making many armors repair like helmet_army is going to make them close to unrepairable, because army helmets are not craftable, and thus difficulty 10 to repair.

@ymber ymber deleted the survivor_helmets branch January 30, 2020 06:37
@Brian-Otten Brian-Otten mentioned this pull request Jan 30, 2020
Merged
va5h added a commit to va5h/Cataclysm-DDA that referenced this pull request Jan 30, 2020
@va5h
Revert "Merge pull request CleverRaven#37524 from ymber/survivor_helm…
a047ac9 
…ets"

This reverts commit e26f2ea, reversing
changes made to bbc4cf2.

Yup, him again.
On a rational side, recipes' difficulty and crafting materials are definitely no match for the resulting uber-helmets.
@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/obsolete-survior-helmets/22653/3

@weekly-digest weekly-digest bot mentioned this pull request Feb 2, 2020
Closed
@sharkfinsouperman sharkfinsouperman mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ymber @Brian-Otten @kevingranade @ZhilkinSerg