Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to basement_bionic from region settings #37545

Conversation

ralreegorganon
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Fixes #37539

After the basement_bionic overmap terrain was made rotatable, all of these region references in mods to the overmap terrain caused errors because the basement_bionic overmap terrain id is not valid in those contexts (they need the full rotated version, e.g. basement_bionic_north).

However, those entries shouldn't even be present there any more--the basement is now spawned as part of a city_building entry rather than randomly attached to a random house entry, and because the house entry is really only there for legacy reasons until we fully deprecate this entire method of randomly stitching together basements and houses, there is no reason to retain this one in the region settings at all.

This all got taken care of in the main region settings, but the desert_test region, desert region mod, rural biome mod, and Aftershock all still had the incorrect entry.

Describe the solution

Remove the basement_bionic entry from the basement sections in all the aforementioned region settings and region overlays.

Testing

Applied the changes and then created new worlds with each of Aftershock, Desert Region, and Rural-Only Mapgen applied exclusively in turn and verified that the error no longer occurs.

Note that you cannot do the High Tech Low Life start with the Desert Region applied because it does not include the house that has this basement. I could've added it, but the entire house setup for that mod is basically outdated and should be revisited separately.

@ralreegorganon ralreegorganon added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display <Bugfix> This is a fix for a bug (or closes open issue) labels Jan 30, 2020
@ZhilkinSerg ZhilkinSerg merged commit 97582b1 into CleverRaven:master Jan 30, 2020
@ralreegorganon ralreegorganon deleted the fix-bionic-basement-region-references branch April 7, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"basement_bionic" error
2 participants