Remove all references to basement_bionic from region settings #37545
+5
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fixes #37539
After the
basement_bionic
overmap terrain was made rotatable, all of these region references in mods to the overmap terrain caused errors because thebasement_bionic
overmap terrain id is not valid in those contexts (they need the full rotated version, e.g.basement_bionic_north
).However, those entries shouldn't even be present there any more--the basement is now spawned as part of a city_building entry rather than randomly attached to a random
house
entry, and because thehouse
entry is really only there for legacy reasons until we fully deprecate this entire method of randomly stitching together basements and houses, there is no reason to retain this one in the region settings at all.This all got taken care of in the main region settings, but the desert_test region, desert region mod, rural biome mod, and Aftershock all still had the incorrect entry.
Describe the solution
Remove the
basement_bionic
entry from the basement sections in all the aforementioned region settings and region overlays.Testing
Applied the changes and then created new worlds with each of Aftershock, Desert Region, and Rural-Only Mapgen applied exclusively in turn and verified that the error no longer occurs.
Note that you cannot do the High Tech Low Life start with the Desert Region applied because it does not include the house that has this basement. I could've added it, but the entire house setup for that mod is basically outdated and should be revisited separately.