Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell books show up in the [R]ead menu #37560

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Jan 30, 2020

Summary

SUMMARY: Interface "Spell books show up in the [R]ead menu"

Purpose of change

Spell books show up in the [R]ead menu

Describe the solution

Add check in game_inventory to allow item with the "learn_spell" use as readable material.

Describe alternatives you've considered

Testing

https://imgur.com/b3pyPYL

Additional context

This might be a bit too hacky

@Qrox
Copy link
Contributor

Qrox commented Jan 30, 2020

I'm not sure why spellbooks weren't put in the book category in the first place.

@Fris0uman
Copy link
Contributor Author

Because they're not actually books. Learning spells works through an "use_action".

@I-am-Erk I-am-Erk added [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 30, 2020
@ZhilkinSerg ZhilkinSerg merged commit cf81aeb into CleverRaven:master Jan 31, 2020
@Fris0uman Fris0uman deleted the readspell branch January 31, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants