Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few wrong coordinate conversions that cause generation of meaningless overmaps #37581

Merged
merged 3 commits into from
Jan 31, 2020

Conversation

park66665
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Fix a few wrong coordinate conversions that cause generation of meaningless overmaps"

Purpose of change

  1. Playing a game for a long time
  2. Meaningless overmap files, meaningless overmap files everywhere!
    Screenshot_2020-01-31_17-30-12
    Screenshot_2020-01-31_17-31-50

Describe the solution

Fix whatever that pops up while using gdb. I found and fixed two.
Another bug bites the dust
Screenshot_2020-01-31_03-53-01

As this PR fixes wrongly used coordinate conversions, it will mend slightly(?) broken things.

Describe alternatives you've considered

  1. Not doing this and go playing SS13 instead.
  2. Not doing this and enjoying life playing A Hat in Time.
  3. Restrict the power of generating overmaps that is given too easily. e.g. replacing overmapbuffer::get with overmapbuffer::get_existing. I AM LOOKING AT YOU, overmapbuffer::ter!

Testing

It compiles and passes test. I had no problems playing after the changes.
Screenshot_2020-01-31_17-26-28

Additional context

This is capable of reducing future save folder's size by up to 30% or something.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jan 31, 2020
@park66665
Copy link
Contributor Author

Waiiiiit did I say duck-tape instead of duct-tape? Bruh, I guess VS Code doesn't spellcheck commit comments...

@ZhilkinSerg ZhilkinSerg added the Mechanics: Weather Rain, snow, portal storms and non-temperature environment label Jan 31, 2020
@ZhilkinSerg ZhilkinSerg merged commit 1eb07c7 into CleverRaven:master Jan 31, 2020
@va5h
Copy link

va5h commented Feb 3, 2020

Waiiiiit did I say duck-tape instead of duct-tape? Bruh, I guess VS Code doesn't spellcheck commit comments...

Might solve a mystery
Or rewrite history!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Map / Mapgen Overmap, Mapgen, Map extras, Map display Mechanics: Weather Rain, snow, portal storms and non-temperature environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants