Fix a few wrong coordinate conversions that cause generation of meaningless overmaps #37581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix a few wrong coordinate conversions that cause generation of meaningless overmaps"
Purpose of change
Describe the solution
Fix whatever that pops up while using gdb. I found and fixed two.
Another bug bites the dust
As this PR fixes wrongly used coordinate conversions, it will mend slightly(?) broken things.
Describe alternatives you've considered
overmapbuffer::get
withovermapbuffer::get_existing
. I AM LOOKING AT YOU,overmapbuffer::ter
!Testing
It compiles and passes test. I had no problems playing after the changes.
Additional context
This is capable of reducing future save folder's size by up to 30% or something.