Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool belt rework #37599

Merged
merged 7 commits into from
Apr 2, 2020
Merged

Conversation

RarkGrames
Copy link
Contributor

Summary

SUMMARY: Content "Reworked the tool belt to be customizable"

Purpose of change

Reworking the tool_belt to be able to be customized and all-around more useful

Describe the solution

  • It has the "rigid": false attribute so when it's empty, takes only 2 encumbrance
  • Can store tools and smaller blades
  • Can store up to 6 items

Encumbrance values:

  • A multi-tool: 3 enc
  • A crowbar: 6 enc
  • Hammer, hacksaw, wood saw, wrench, screwdriver set (survivor utility belt): 16 enc
  • Pair of bolt cutters, hatchet, hunting knife, crowbar, multi-tool, PR-24 baton (example full survivor toolset): 19

This makes the tool belt customizable, to be able to choose the exact tools (unlike the survivor belt), and to be able to decide on the "encumbrance/tools needed" balance.

Testing

Spawned the item and tried to store 8-10 different tools in it.

Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
@wapcaplet
Copy link
Contributor

Looks like a useful and reasonable change. I’ve always wondered why it could hold so little.

@Brian-Otten
Copy link
Contributor

Pretty easy to see this edit doesn't do anything weird and should work as intended, and would make the tool belt much nicer in both realism and gameplay usage. Hope to see this merge.

"max_weight": 1000,
"holster_prompt": "Store tool or blade",
"holster_msg": "You put your %s in your %s",
"multi": 6,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this require increasing the recipe requirements to 6 pouches(or 7, since the 1L storage is still there)?

"draw_cost": 50,
"flags": [ "BELT_CLIP" ]
"flags": [ "BELT_CLIP", "SHEATH_KNIFE", "SHEATH_SWORD" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of SHEATH_SWORD seems risky, especially combined with increasing volume to 1.5L. What’s the encumbrance like with six two-by-swords or wakizashis attached?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32 and 38 encumbrance.

Copy link

@ghost ghost Feb 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sheathing swords in this will probably get reverted once KorG gets through the holster refactor, since swords would be too long to fit in the pouch.

@@ -197,8 +197,9 @@
"id": "tool_belt",
"type": "ARMOR",
"name": "tool belt",
"description": "A common belt with pockets and four small belt loops. Widely used by handymen and electricians.",
"description": "A common belt with pockets, loops and sheaths to store up to six tools or blades. Widely used by handymen and electricians.",
"weight": "960 g",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an increase, given the pouch amount being increased.

@ifreund ifreund added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Feb 1, 2020
Co-Authored-By: Jianxiang Wang (王健翔) <qrox@sina.com>
@kevingranade kevingranade merged commit 6fef020 into CleverRaven:master Apr 2, 2020
twadams pushed a commit to twadams/Cataclysm-DDA that referenced this pull request Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants