Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extracts and concentrates pt4 #37946

Merged

Conversation

NastyNate2612
Copy link
Contributor

adds small vacuum oven and all associated states

Summary

SUMMARY: Content "pt4 of my extracts and concentrates mod into mainline"

Describe the solution

-small vac oven works like the char_kiln but uses battery power at the same time. there is a deconstruction recipe for this item just like the char_kiln.

Testing

Crafted and used, runs good

Additional context

So this item is just a placeholder until i can create a furniture item that does the same function. Essentially i tried to make this item work similar to the rock_kiln (whether u put 1 log or 5 logs it takes the same amount of time to "cook") but i cant do it without c++ additons. i will create a draft PR with all the furniture constructions and deconstruct recipe info so someone can help me with that. the only bug i couldnt work out is if you dont "use" the finished vac_oven_on item before the battery runs out then it reverts back to filled_vacuum_oven

adds small vacuum oven and all associated states
@curstwist curstwist added 0.E Content Freeze Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON and removed 0.E Content Freeze labels Feb 12, 2020
@ZhilkinSerg ZhilkinSerg changed the base branch from master to dev March 16, 2020 12:03
@ZhilkinSerg ZhilkinSerg force-pushed the dev branch 3 times, most recently from 924f105 to 39e00e3 Compare March 18, 2020 07:00
@ZhilkinSerg ZhilkinSerg force-pushed the dev branch 3 times, most recently from ad63e77 to 8e68539 Compare April 1, 2020 12:18
@kevingranade kevingranade force-pushed the dev branch 4 times, most recently from 621a68e to b7106d0 Compare April 2, 2020 07:42
@ZhilkinSerg ZhilkinSerg force-pushed the dev branch 3 times, most recently from 0f30a43 to d432807 Compare April 2, 2020 12:55
@ZhilkinSerg ZhilkinSerg changed the base branch from dev to master April 2, 2020 21:46
more accurate representation of real power usage
@NastyNate2612
Copy link
Contributor Author

Ok so the Vacuum oven works but the only problem with it is that if you dont activate the item after its done purging before it runs out of batteries it reverts back to a filled small vacuum oven.

@kevingranade kevingranade merged commit b9b0ce1 into CleverRaven:master Apr 27, 2020
Drewscriver pushed a commit to Drewscriver/Cataclysm-DDA that referenced this pull request Apr 30, 2020
adds small vacuum oven and all associated states
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants