Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comestible modern json #38135

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Comestible modern json #38135

merged 3 commits into from
Feb 18, 2020

Conversation

snipercup
Copy link
Contributor

Summary

SUMMARY: none

Purpose of change

Contributes to #36610 and #36110

Describe the solution

Change name to object
change spoils_in to string
Change volume to string

Describe alternatives you've considered

Not changing

Testing

spoils_in produces the same amount of time before and after the change:
image
image
image
image

@ZhilkinSerg ZhilkinSerg added the [JSON] Changes (can be) made in JSON label Feb 18, 2020
@ZhilkinSerg ZhilkinSerg merged commit bcfe074 into CleverRaven:master Feb 18, 2020
@snipercup snipercup deleted the Comestible-modern-json branch February 18, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants