Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak surrounded scenario. #39860

Merged
merged 2 commits into from
Apr 27, 2020
Merged

Tweak surrounded scenario. #39860

merged 2 commits into from
Apr 27, 2020

Conversation

arijust
Copy link
Contributor

@arijust arijust commented Apr 24, 2020

Summary

SUMMARY: Bugfixes "Add fire/police stations to surrounded scenario."

Purpose of change

Close #39851

Describe the solution

Add sloc_fire_station and sloc_police to list in that scenario.

@Brian-Otten
Copy link
Contributor

Good to see these return, some of my favorite starts.

@curstwist curstwist added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Scenarios New Scenarios, balancing, bugs with scenarios labels Apr 24, 2020
Copy link
Contributor

@ralreegorganon ralreegorganon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One difference here with the previous behavior is that previously the start location would target just the "main floor" location, but now the prefix match that it uses after #38151 means it will also allow spawning on the roof. Unfortunately because of how the actual location in game is rated and picked for a start, you can actually then end up on the roof of an adjacent building, which doubly defeats the point of being surrounded and in the fire/police station.

I'd suggest changing the definitions of the fire station and police station starting locations such that they don't include the roof. Something like this:

diff --git a/data/json/start_locations.json b/data/json/start_locations.json
index a1055c362b..90272b04d1 100644
--- a/data/json/start_locations.json
+++ b/data/json/start_locations.json
@@ -261,13 +261,20 @@
     "type": "start_location",
     "id": "sloc_fire_station",
     "name": "Fire Station",
-    "terrain": [ { "om_terrain": "fire_station", "om_terrain_match_type": "PREFIX" } ]
+    "terrain": [
+      { "om_terrain": "fire_station", "om_terrain_match_type": "TYPE" },
+      { "om_terrain": "fire_station_1", "om_terrain_match_type": "TYPE" }
+    ]
   },
   {
     "type": "start_location",
     "id": "sloc_police",
     "name": "Police Station",
-    "terrain": [ { "om_terrain": "police", "om_terrain_match_type": "PREFIX" } ]
+    "terrain": [
+      { "om_terrain": "police", "om_terrain_match_type": "TYPE" },
+      { "om_terrain": "police_1", "om_terrain_match_type": "TYPE" },
+      { "om_terrain": "police_2", "om_terrain_match_type": "TYPE" }
+    ]
   },
   {
     "type": "start_location",

Police station and Fire station.
@ralreegorganon ralreegorganon merged commit 7a27c35 into CleverRaven:master Apr 27, 2020
@arijust arijust deleted the scenario_surrounded branch April 27, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Scenarios New Scenarios, balancing, bugs with scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't start at either the police station or fire station
4 participants