Replace Makefile check for defines with checks for values #39905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was confusing that setting something like LTO to 0, instead of 1 would behave the same as setting it to 1. To address this, change Makefile checks for variables that will only have values of either 1 or 0 from checking if they're defined to checking if they equal 1.
anothersimulacrum
force-pushed
the
makefile-clean
branch
from
32fce12 to
828299e
Compare
ifreund
added
<Bugfix>
Drewscriver
pushed a commit
to Drewscriver/Cataclysm-DDA
that referenced
this pull request
Apr 30, 2020
It was confusing that setting something like LTO to 0, instead of 1 would behave the same as setting it to 1. To address this, change Makefile checks for variables that will only have values of either 1 or 0 from checking if they're defined to checking if they equal 1.
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Check values of variables in makefile instead of simply if they are defined"
Purpose of change
It was confusing that setting something like LTO to 0, instead of 1 would behave the same as setting it to 1.
Describe the solution
To address this, change Makefile checks for variables that will only have values of either 1 or 0 from checking if they're defined to checking if they equal 1.
Testing
I could still build with the same options, then various CI checks should exercise a good deal of the other options.