Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change line-color to light_red for disabled option #39934

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Change line-color to light_red for disabled option #39934

merged 2 commits into from
Apr 26, 2020

Conversation

Pupsi-Mupsi
Copy link
Contributor

@Pupsi-Mupsi Pupsi-Mupsi commented Apr 26, 2020 •
edited
Loading

Summary

SUMMARY: None

Purpose of change

Change line-color to light_red to match false and disabled option.

  • Made sure that this works with translated text and for the value off as well.

Before:

grafik

After
grafik

grafik

grafik

ifreund
ifreund approved these changes Apr 26, 2020
View reviewed changes
Copy link
Contributor

@ifreund ifreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ifreund ifreund merged commit 2588a0b into CleverRaven:master Apr 26, 2020
@Pupsi-Mupsi Pupsi-Mupsi deleted the PM-option-line branch April 26, 2020 20:50
Drewscriver pushed a commit to Drewscriver/Cataclysm-DDA that referenced this pull request Apr 30, 2020
@Pupsi-Mupsi @Drewscriver
Change line-color to light_red for disabled option (CleverRaven#39934)
d510e82 
* Change LineColor to light_red for disabled option

* Add option off and fix for translations
This was referenced May 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifreund ifreund ifreund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pupsi-Mupsi @ifreund