Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using CLANG=0 to compile with gcc #39947

Merged
merged 1 commit into from
May 26, 2020

Conversation

anothersimulacrum
Copy link
Member

Summary

SUMMARY: None

Purpose of change

Make specifying CLANG=0 in a make command work properly.

Describe the solution

If clang is not defined, set it to 0. Only use clang when clang != 0. Once CLANGCMD has been set, set clang 1, and use that to determine if clang is being used or not later in the makefile.

Testing

Can build with and without clang.

Makefile Outdated Show resolved Hide resolved
@anothersimulacrum anothersimulacrum marked this pull request as draft April 27, 2020 05:56
@mlangsdorf mlangsdorf added the Code: Build Issues regarding different builds and build environments label Apr 30, 2020
@anothersimulacrum anothersimulacrum marked this pull request as ready for review May 26, 2020 00:38
@kevingranade kevingranade merged commit 0f66604 into CleverRaven:master May 26, 2020
@anothersimulacrum anothersimulacrum deleted the clangfile branch May 26, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants