Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain lightning CBM does electric damage instead of stab #39949

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Chain lightning CBM does electric damage instead of stab #39949

merged 1 commit into from
Apr 27, 2020

Conversation

Dacendeth
Copy link
Contributor

@Dacendeth Dacendeth commented Apr 27, 2020

Summary

SUMMARY: Balance "Chainlightning CBM shot does electric damage now"

Purpose of change

The chainlightning CBMs shot does stab damage, which makes it able to wound shocker zombies with the initial projectile, this feels rather wrong as they're immune to electric shocks.

Describe the solution

Changed the fake item that the cbm uses from stab to electric damage.

Describe alternatives you've considered

Leaving it as it is.

Testing

Spawned a shocker zombie, a incandescent hulk, a shocker brute and shot them with the CBM and was unable to hurt any of them anymore.
Spawned a normal zombie and a kevlar hulk, damage to them was consistant and worked.

Additional context

@KorGgenT
Copy link
Member

After inspecting the code with this change, it's still doing stab damage.
in player::fire_gun()
image
So to make this actually do electric damage, some more bughunting and C++ bugfixing is going to have to happen.

@KorGgenT KorGgenT added [JSON] Changes (can be) made in JSON Bionics CBM (Compact Bionic Modules) labels Apr 27, 2020
@anothersimulacrum
Copy link
Member

Ugh, that's probably my fault. I'll look into that.

@Dacendeth
Copy link
Contributor Author

Dacendeth commented Apr 27, 2020

Huh that's weird, wonder why changing it made it not hurt the shock zombies anymore when I tested it then.

@anothersimulacrum
Copy link
Member

Works for me?

Thread 1 "cataclysm-tiles" hit Breakpoint 2, player::fire_gun (this=0x555559e4ddc0, target=..., shots=1, gun=...) at src/ranged.cpp:478
478	        auto shot = projectile_attack( make_gun_projectile( gun ), pos(), aim, dispersion, this, in_veh );
(gdb) n
479	        curshot++;
(gdb) p shot
$5 = {proj = {impact = {damage_units = std::vector of length 1, capacity 1 = {{type = DT_ELECTRIC, amount = 16, res_pen = 0, res_mult = 1, damage_multiplier = 0.875, unconditional_res_mult = 1, unconditional_damage_mult = 1}}}, speed = 1000, range = 10,
    critical_multiplier = 2, proj_effects = std::set with 3 elements = {[0] = "BOUNCE", [1] = "LIGHTNING", [2] = "WIDE"}, drop = std::unique_ptr<item> = {get() = 0x0}, custom_explosion = std::unique_ptr<explosion_data> = {get() = 0x55556b2a3150}}, hit_critter = 0x0,
  dealt_dam = {dealt_dams = {_M_elems = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0}}, bp_hit = bp_torso}, end_point = {x = 67, y = 69, z = 0}, missed_by = 1}

@KorGgenT KorGgenT merged commit 43adeb0 into CleverRaven:master Apr 27, 2020
Drewscriver pushed a commit to Drewscriver/Cataclysm-DDA that referenced this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants