Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barbute helm now covers eyes #39950

Merged
merged 2 commits into from Apr 28, 2020
Merged

Barbute helm now covers eyes #39950

merged 2 commits into from Apr 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 27, 2020

Summary

SUMMARY: Balance "Barbute helm now covers eyes"

Purpose of change

Going by the item's description, I think the helmet should partially protect the eyes and mouth.

Describe the solution

Change the helm to cover the eyes and mouth.

Describe alternatives you've considered

Leave it as it is.

Testing

Spawned the helmet in. It now covers the head, eyes, and mouth.

Additional context

@Mecares
Copy link
Contributor

Mecares commented Apr 27, 2020

I dont think it should cover the eyes and mouth.

Barbute Helm

@ghost
Copy link
Author

ghost commented Apr 27, 2020

I dont think it should cover the eyes and mouth.

Barbute Helm

Yeah, I looked at the image too while I was making this PR. I thought it would be fine if I kept the coverage at 90% since it doesn't completely cover the face. My logic was that even with the openings it would still make it harder for someone to hit your eyes and mouth.

@Mecares
Copy link
Contributor

Mecares commented Apr 27, 2020

Yes i agree on that but as far as i remember there are no hits registered towards eyes or mouth since you only have head hitpoints but they can still be encumbered and i do not see how this helmet makes breathing harder.

@ghost
Copy link
Author

ghost commented Apr 27, 2020

Zombies can swipe you in the eyes for head damage and a temporary blind. I agree that this shouldn't make it harder to breathe, though.
image

@ghost ghost changed the title Barbute helm now covers eyes and mouth Barbute helm now covers eyes Apr 27, 2020
@Rivet-the-Zombie Rivet-the-Zombie merged commit 1700745 into CleverRaven:master Apr 28, 2020
@ghost ghost deleted the barbute-helm-covers-eyes-and-mouth branch May 1, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants