Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds fragile melee flag to fake weapons and chainsaws #39959

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

Brian-Otten
Copy link
Contributor

@Brian-Otten Brian-Otten commented Apr 27, 2020

Summary

SUMMARY: Balance "Adds fragile melee flag to fake weapons and chainsaws"

Purpose of change

Weapons that you'd expect to be fragile aren't fragile.

Describe the solution

Add the fragile flag to melee weapons that would break rapidly if used in combat. I didn't do a full audit of the items so this pass was the obvious offenders, fake medieval weapons and activated chainsaws.

@Zireael07
Copy link
Contributor

Fake weapons are metallic, not plastic, so I don't think they'd be fragile. Chainsaws, though, good call.

@Brian-Otten
Copy link
Contributor Author

When i think of the fake weapons i think of something like this:
https://twitter.com/klara_sjo/status/1252373946730569729
Flimsy and fragile weapons that only meet the bare minimum requirements to be similar in appearance. Just being "made of metal" won't make them sturdy.
For weapons that are slightly better fakes we have all the inferior weapons, which have somewhat higher stats and are not as fragile.

@kevingranade
Copy link
Member

Yea I agree, "fake" is intended to be "not actually a credible example of this kind of weapon", wheres "inferior" is "a substantially substandard example of this kind of weapon".
Fragile definitely fits for "fake".

@Brian-Otten
Copy link
Contributor Author

Oh man i really need to stop doing these PR's when tired, those were some pretty stupid mistakes. Thanks for the review.

@kevingranade kevingranade merged commit 3bdcb87 into CleverRaven:master Apr 27, 2020
ZhilkinSerg pushed a commit to ZhilkinSerg/Cataclysm-DDA that referenced this pull request Apr 27, 2020
Drewscriver pushed a commit to Drewscriver/Cataclysm-DDA that referenced this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants