Blazemod Mini-PR: Refactor and modernise blazemod ammo #40010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modernises damage to vanilla standard for ammo in blazemod, separates out the charcoal override used by diamond content into its own derivative that has been given a placebo recipe, and gives proper prefixes to related content. Some changes inspired by a misplaced entry that is reminiscent of vortex stuff but definitely diamond.
Modernises damage to vanilla standard for ammo in blazemod, separates out the charcoal override used by diamond content into its own derivative that has been given a placebo recipe, and gives proper prefixes to related content. Some changes inspired by a misplaced entry that is reminiscent of vortex stuff but definitely diamond.
…-Loop/Cataclysm-DDA into soupdeloop-blazemod-PR25
|
Yikes, that linting commit wasn't as clean as I'd like. Sorry! |
Soup-de-Loop
commented
Apr 29, 2020
| @@ -63,19 +63,6 @@ | |||
| [ [ "vortex_stone", 1 ] ] | |||
| ] | |||
| }, | |||
There was a problem hiding this comment.
The spiral_matrix is actually something belonging to the diamond group, renamed to diamond_matrix in the diamond group to avoid this confusion.
ZhilkinSerg
added
[JSON]
Drewscriver
pushed a commit
to Drewscriver/Cataclysm-DDA
that referenced
this pull request
Apr 30, 2020
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Mods "Refactor and modernise blazemod ammo"Purpose of change
This is the twenty fifth PR in bringing the changes in #37497 about, by breaking each change into small parts that are easier to skim and understand.
Describe the solution
Modernises damage to vanilla standard for ammo in blazemod; separates out the charcoal override used by diamond content into its own derivative that has been given a placebo recipe; and gives proper prefixes to diamond and vortex items related to this ammo to provide clarity.
Testing
Straightforward changes inspired by but not included in #37497, probably might work for now but its compatibility will be broken again when ID's are changed.
Additional context
More PR's to come, consider incomplete by itself, part of a whole.
P.S: Some changes inspired by a misplaced entry that is reminiscent of vortex stuff but definitely diamond, causing confusion.