Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Some data were not reset when new world was loaded in a session where a world with different mods was previously loaded. Current PR calls
reset
functions for some object types.Helps with things like #40038.
Describe the solution
skill_boost
,clothing_mods
andmorale_type
data;Describe alternatives you've considered
Rewrite DynamicDataLoader, so all types of functions (
load
,reset
,finalize
) would be stored in a single collection and can be easily audited.Testing
Make sure it compiles and game starts/loads without errors.