Log locale info to help debug i18n #40054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In each of the three places where the global locale is changed, log the results of that change to the debug log.
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: I18N "Record locales in debug.log to assist with i18n debugging"
Purpose of change
In #40041 people are reporting some very strange sorting results.
Describe the solution
To understand what's going on add logging to all the places which modify the locale so we can see what it's being set to.
Describe alternatives you've considered
Asking people to debug the issue themselves.
Testing
Ran the game; observed the logs exist for me locally.
Additional context
The way locales are handled is scattered across various files in a rather unhelpful way. Maybe this can be consolidated?..