Remove VIEW_OFFSET_X/Y #40055
Merged
Remove VIEW_OFFSET_X/Y #40055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
added
[C++]
ifreund
approved these changes
May 1, 2020
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
VIEW_OFFSET_X/Yare never set to values other than 0. According to a comment ingame.cppthey were used to center the terrain window when the screen exceeds the required size. Since we now use the full screen space for the terrain window, they are essentially dead code now and can be removed. Most of the game windows do not take these two values into consideration, either, and even the terrain window itself glitched when I tested assigning non-zero values to the two variables.Describe the solution
Remove the variables altogether.
Describe alternatives you've considered
Leave them as is to be revived in the future.
Testing
Opened the affected menus and they all displayed fine.