Fix time_duration formatting #40068
Merged
Fix time_duration formatting #40068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For time_durations in excess of 1 week, the formatting code would do the wrong thing. It tried to format two units worth of time (e.g. 1 week and 2 days) but the second unit could never be larger than hours. Now it can be anything up to seasons.
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix time duration formatting for periods in excess of 1 week"
Purpose of change
For time_durations in excess of 1 week, the formatting code would do the wrong thing. It tried to format two units worth of time (e.g. 1 week and 2 days) but the second unit could never be larger than hours.
Describe the solution
Add more cases to the code; now it can be anything up to seasons.
Describe alternatives you've considered
Arguably it would be better to say e.g. "1 hour and 0 minutes" than "1 hour and 3 seconds", but I don't want to change that now.
Testing
Added some unit tests.
Additional context
Discovered while working on achievements features.