DPS test cleanup #40073
Merged
DPS test cleanup #40073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Capture more values. - Verify that weapon is wielded. - Remove some dead code.
Having a martial arts style selected can cause problems for the melee tests. Ensure that we don't have one set.
ZhilkinSerg
added
Code: Tests
This was referenced May 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fix a particular test failure for the
effective_dps_tests.When the avatar happened to have particular martial arts active (the one I observed was Taekwondo) it would prevent their weapon having any effect on combat, which caused the "accuracy increases success" test to be nothing more than a coin flip.
Describe the solution
Ensure that
clear_characteralso unsets martial art.Describe alternatives you've considered
None
Testing
Tests now pass where before they failed.
Additional context
This failure showed up on one of my PRs (#40041, I think).