Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup mall part 1 #40080

Merged
merged 1 commit into from
May 2, 2020
Merged

cleanup mall part 1 #40080

merged 1 commit into from
May 2, 2020

Conversation

curstwist
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Mall mapgen cleanup: merge roof maps, clean up terrains. Split up mapgen into several files."

Purpose of change

Getting ready to do more work on the mall, so I wanted to clean it some to improve readability and navigation.

Describe the solution

Merged the roof maps, used palettes and did some terrain fixes and improvements.
Move the maps into a dedicated folder and split them up by z level.

Testing

spawned in world to check mapgen.

Additional context

I'm probably adding a basement to the mall, so I wanted to split these up by z level for my sanity.
I still need to look at the ground and 2nd floor for merging map opportunities (like the parking lots).

Future plans include: adding the basement with subway access, updating the ground floor, adding an NPC faction that makes use of update_mapgen.

@curstwist curstwist added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels May 2, 2020
Copy link
Contributor

@ifreund ifreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants