Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a pointless door #41695

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Conversation

hexagonrecursion
Copy link
Contributor

@hexagonrecursion hexagonrecursion commented Jun 30, 2020

Summary

SUMMARY: none

Purpose of change

One of the apartment layouts has a second story door that goes outside. I find it unlikely that the architect would anticipate the need for jumpimg from the second story down to the pavement below.

Describe the solution

Replace the door with a wall

Describe alternatives you've considered

I have not considered any alternatives

Testing

  1. Test that a new game can be started
  2. Use the overmap editor to place the s_apt special
  3. Check that there is a wall where the door used to be

Additional context

none

This door can only be used by a mary poppins
@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Jun 30, 2020
@hexagonrecursion hexagonrecursion marked this pull request as ready for review June 30, 2020 17:18
@ZhilkinSerg ZhilkinSerg merged commit 53a0869 into CleverRaven:master Jun 30, 2020
@hexagonrecursion hexagonrecursion deleted the remove-door branch June 30, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants