Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset harvests to avoid otherworldly errors #47938

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

wapcaplet
Copy link
Contributor

Summary

Bugfixes "Reset harvests to avoid otherworldly errors"

Purpose of change

Fix #47932

Describe the solution

Add a harvest_list::reset() method to clear the previously loaded harvest list, and call it from unload_data().

Testing

See original issue. Basically, create a new character in a world with a mod enabled, save, then (without quitting the game) create another world with another character, without mods.

Harvest data from the previously loaded world was not reset, leading to
a bunch of errors from unrelated mods in a different world.

Add a harvest_list::reset() method to clear the previously loaded
harvest list, and call it from unload_data().

Fix CleverRaven#47932
@wapcaplet wapcaplet added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world labels Mar 8, 2021
@ZhilkinSerg ZhilkinSerg merged commit d8dc8ec into CleverRaven:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors with mods loaded in a different world
2 participants