Add new weather type: Portal storms

[Ramza13]

Summary

Content "Add new weather type: Portal storms."

Purpose of change

Add new weather type: Portal Storms.
Give weather some teeth. Add new kinds of challenges that scale with time to help extend endgame.

Describe the solution

During the cataclysm a giant portal storm overtook earth and while it was the largest it wasn't the last of these storms. From time to time the barrier between realities thins and portal storms occur.

GOALS:

• Portal storms grow stronger the longer they last and start stronger each time they happen. Early game they should be a minor nuisance but late game they should be deadly.
• This scaling involves both new effects showing up and existing ones getting stronger.
• The current night messages( Add unnatural night time sky activity #48244) has been subsumed into this. They are warning signs that a portal storm is approaching.
• Though the name has portal in it not all effects are strictly speaking a portal opening and stuff coming out. The barrier between realities is thinning and not everything bleeding over is localized. Reality as we know it is breaking.
• Create a scenario where portal storms start off very strong and one where a single strong storm is ongoing
• No permanent changes to the world. While unhardcoding weather I came across a comment mentioning that lightning used to start fires. The comment said it was removed because it meant players would leave their bases during lightning storms so once outside of the reality bubble they would be immune to burning down. To avoid the same issue all changes including monsters made by portal storms will be temporary. So while it would be fun, no rearranging terrain or spawning random buildings unless the effect is short-lived

DETAILS:

• At present portal storms can cause: messages describing reality breaking apart, radiation, monster spawns, background light levels changing. and smoke appearing everywhere.
• As long as you stay indoors you are safe from portal storms. Possibility when they get strong enough this will not be the case.

Current added monsters:

• Wraith. Small quick, low hp and harmless, all they do is make you need to sleep a little more. Minor nuisance.
• Impossible shape. Have a ranged attack to make you unhappy and have nightmares which reduce how refreshing sleep is. Also incapable of hurting you, meant to combo with the wraith a bit.
• Gigantic appendage. Might need a better name(the idea is its just a small appendage, maybe a finger, of something giant. Large, strong and all but invincible. Don't try to kill it, just avoid it till it fades back out.

Describe alternatives you've considered

The first version of this was #41067 which was inspired by the TV show The Mist. That PR's rejection led me on a long trail of work including unhardcoding weather and creating effect_on_conditions. Now loads of PR's later its time to do this right. This time hopefully fitting the setting better.

Testing

Additional context

[Theawesomeboophis]

This sounds like an interesting and challenging encounter, I can't wait.

[Broken27]

I have been waiting for this since forever, this is really great.

[Essnato]

I think a cool addition would be to temporarily buff all blob based enemies like slimes, either making them much smarter or stronger since they have a stronger connection to their core

[John-Candlebury]

Really cool!
Try to give 5-point-anchors/ the phase immersion suit some use protecting against these, if possible

[Pseudogeist]

This looks DF levels of fun. I can't wait! Regarding radiation: If it's not going to be afflicting tiles with local radiation the message is a little odd, it's as if the portal is targeting you specifically, which it kind of is. Some new kind of field effect or entity might be better, maybe emitting green light as a warning to stay away? Maybe let them spawn on creatures and cause burning and temperature increase.

Also, a monster to portal storms with some teleporting ability, ability to phase through all impassable objects (including solid rock) which grabs the player and, after a set amount of moves, violently teleports them. That would make staying indoors much harder, and staying below ground potentially deadly. I imagine them as rope-like, quivering things that behave more like eye floaters or jellyfish tentacles than creatures, drifting through our dimension until they detect something to respond to.

[MagratGarlick]

Can we get it to cause Mutations as well (unless sufficient environment protection's worn or indoors)? Like, Etherwind?

[actual-nh]

Nice!

[lgtm-com]

This pull request introduces 1 alert when merging 8b0a6e0 into 3f3a6af - view on LGTM.com

new alerts:

• 1 for Declaration hides parameter

[Abexis]

Could gigantic appendages more susceptible to "defeat"?

While I enjoy them conceptually, I dislike the idea that no matter what stage of the game the player is in, the creature cannot be destroyed. The death text could read, "the appendage flinches back through the portal." Sort of the equivalent of poking your finger into a mousehole abd having the mouse bite you.

I suggest a reduction in HP from 1,000,000,000 to something "manageable", like 2000. That preserves the idea that its an incredibly powerful creature meant to be run from, without making it "invincible"