Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bipod when shooting from prone #51472

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Conversation

ildifa
Copy link
Contributor

@ildifa ildifa commented Sep 8, 2021

Summary

Features "Use bipod when shooting from prone"

Purpose of change

Automatically use the bipod mounted on a gun by shooting from the prone position.

Describe the solution

Added a condition in the code which checks if the terrain is suitable to use the bipod.
Now it checks if the terrain is suitable OR if the player is prone.

Describe alternatives you've considered

Testing

Additional context

@Joshua-Chin
Copy link
Contributor

Going prone doesn't take any time. If we're going to add non-movement related benefits (like bipod usage), we should consider adding a move cost. Tactically, it would force players to choose between a more stable firing position, and a faster initial shot.

@actual-nh actual-nh added <Enhancement / Feature> New features, or enhancements on existing [C++] Changes (can be) made in C++. Previously named `Code` Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Mechanics: Aiming Aiming, especially aiming balance labels Sep 8, 2021
@ildifa
Copy link
Contributor Author

ildifa commented Sep 9, 2021

Adding a movecost to going prone (and maybe a higher cost to get back up from prone?) certainly makes sense, but I think it's outside the extent of my ability with C++.
From a purely gameplay perspective, maybe it's not a big deal, as if enemies are close you don't want to be prone anyways. It's possible that players would micro-manage walk->prone->shoot->walk, but it seems quite tedious... I wouldn't do it, at least!

@Joshua-Chin
Copy link
Contributor

My comment isn't intended to block this pull request. It's more of an idea for a subsequent change.

@ZhilkinSerg ZhilkinSerg merged commit dc30d53 into CleverRaven:master Oct 4, 2021
@ildifa ildifa deleted the Prone-bipod branch October 18, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Mechanics: Aiming Aiming, especially aiming balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants