More granular and parallelized translations compiling #51928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettDong
added
Code: Build
BrettDong
changed the title
BrettDong
force-pushed
the
makefile-lang
branch
from
e505811 to
6a0f34c
Compare
BrettDong
force-pushed
the
makefile-lang
branch
from
6a0f34c to
2081e2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Build "More granular and parallelized translations compiling"
Purpose of change
./lang/compile_mo.shis single-threaded and is slow. Inspired by #51731, I think it'd better leveragemake's job parallelism capability.Describe the solution
Write a Makefile to do the job of
./lang/compile_mo.sh.Describe alternatives you've considered
?
Testing
make localization, ormake -C lang, compiles translations as usualmake -j2indeed parallelized translations compilation.Additional context
make localization -j16is super fast