Weakpoints (Part 9): More Documentation #52055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joshua-Chin
added
<Documentation>
|
Some more stuff needs documentation such as how to use default weakpoints. I will try to make a list or add it to the documentation myself |
|
I added additional documentation about default weakpoints. Let me know if there's anything else that needs documenting. This PR is a draft to avoid merge conflicts with PR #52081. It's otherwise ready for review. |
|
I will take a look and add notes about anything I felt confusing. |
Joshua-Chin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Add more documentation to monster weak points. In particular, clarify that
armor_mult,armor_penalty,damage_mult, andcrit_multall expect damage arrays.Describe the solution
Describe alternatives you've considered
Testing
Additional context