Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge Library #52062

Merged
merged 101 commits into from
Oct 7, 2021
Merged

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Oct 3, 2021

Summary

Mods "Forge of Wonders, Library"

Purpose of change

Adds a library and librarian to eliminate people reading scrolls and books on the table near the Pirates.

Describe the solution

Adds additional store to specifically sell spell books and scrolls.

Describe alternatives you've considered

none

Testing

All spawned and dialogue worked appropriately. Was spawning too many rare spellbooks so I've backed that off a smidge.

Additional context

Small library no NPC

Maleclypse and others added 30 commits March 26, 2020 22:57
August 1 2020 Catchup to Master
Catchup for Artifact conversions
@Maleclypse Maleclypse requested a review from KorGgenT as a code owner October 3, 2021 02:24
@Maleclypse Maleclypse marked this pull request as draft October 3, 2021 02:24
@Maleclypse Maleclypse added Items / Item Actions / Item Qualities Items and how they work and interact Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Magiclysm Anything to do with the Magiclysm mod NPC / Factions NPCs, AI, Speech, Factions, Ownership Spawn Creatures, items, vehicles, locations appearing on map labels Oct 3, 2021
@Maleclypse Maleclypse force-pushed the Librarian-of-the-Forge branch 6 times, most recently from 884957c to 9a59893 Compare October 6, 2021 01:01
@Maleclypse Maleclypse force-pushed the Librarian-of-the-Forge branch from 9a59893 to 163fcd8 Compare October 6, 2021 03:45
@Maleclypse Maleclypse marked this pull request as ready for review October 6, 2021 16:38
lint and typos

spare comma

Update books.json

fixes

Update TALK_FORGE_ARDELIA.json

Update books.json

removes broken item

Final
@Maleclypse Maleclypse force-pushed the Librarian-of-the-Forge branch from 163fcd8 to 4d87577 Compare October 7, 2021 03:41
@kevingranade kevingranade merged commit 215b2a4 into CleverRaven:master Oct 7, 2021
@Maleclypse Maleclypse deleted the Librarian-of-the-Forge branch October 7, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Magiclysm Anything to do with the Magiclysm mod NPC / Factions NPCs, AI, Speech, Factions, Ownership Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.