-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forge Library #52062
Merged
kevingranade
merged 101 commits into
CleverRaven:master
from
Maleclypse:Librarian-of-the-Forge
Oct 7, 2021
Merged
Forge Library #52062
kevingranade
merged 101 commits into
CleverRaven:master
from
Maleclypse:Librarian-of-the-Forge
Oct 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update my fork
Post 0.E merge fest
Update fork
Update repo
Update to pockets
Update my Fork
catchup to mainline
August 1 2020 Catchup to Master
Catchup for Artifact conversions
include updated relics
Let's talk relics
catch a mouse
make it up to date
interesting
catchup branch
This reverts commit 9da0eae.
Maleclypse
added
Items / Item Actions / Item Qualities
Items and how they work and interact
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods: Magiclysm
Anything to do with the Magiclysm mod
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
Spawn
Creatures, items, vehicles, locations appearing on map
labels
Oct 3, 2021
Maleclypse
commented
Oct 3, 2021
Maleclypse
commented
Oct 3, 2021
Maleclypse
force-pushed
the
Librarian-of-the-Forge
branch
6 times, most recently
from
October 6, 2021 01:01
884957c
to
9a59893
Compare
Maleclypse
force-pushed
the
Librarian-of-the-Forge
branch
from
October 6, 2021 03:45
9a59893
to
163fcd8
Compare
lint and typos spare comma Update books.json fixes Update TALK_FORGE_ARDELIA.json Update books.json removes broken item Final
Maleclypse
force-pushed
the
Librarian-of-the-Forge
branch
from
October 7, 2021 03:41
163fcd8
to
4d87577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Items / Item Actions / Item Qualities
Items and how they work and interact
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods: Magiclysm
Anything to do with the Magiclysm mod
NPC / Factions
NPCs, AI, Speech, Factions, Ownership
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "Forge of Wonders, Library"
Purpose of change
Adds a library and librarian to eliminate people reading scrolls and books on the table near the Pirates.
Describe the solution
Adds additional store to specifically sell spell books and scrolls.
Describe alternatives you've considered
none
Testing
All spawned and dialogue worked appropriately. Was spawning too many rare spellbooks so I've backed that off a smidge.
Additional context