Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Toolbox Capacity #52118

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Conversation

emarinier
Copy link
Contributor

@emarinier emarinier commented Oct 5, 2021

Summary

None

Purpose of change

Fixes #50163. Namely, updates the volumes of the toolbox to be more realistic.

Describe the solution

Updated volume to 8000 ml and max_contains_volume to 7800 ml.

Describe alternatives you've considered

More or less volume, depending on the exact shape of the toolbox. Changing the max_contains_weight as well.

Testing

I have spawned the toolbox in game and loaded it with a variety of items. The volumes appear accurate.

Additional context

I found a toolbox with similar dimensions:

toolbox

Using these dimensions (but the original long length of 42cm), I calculated what the volume would be if it were a perfect rectangular cuboid:

0.42m * 0.18m * 0.11m * 1000L/1m = 8.316 L

I rounded 8316 ml down to 8000 ml and set the max_contains_volume to 7800 ml.

Additionally, the toolbox can carry all of the items the original poster thought it should be able to with more room left over:

Real toolbox would be able to also take a set of metal files, three more hammers, roll of duct tape three different screwdrivers and a lot of random scrap.

pocket

@Maleclypse Maleclypse added [JSON] Changes (can be) made in JSON Items: Containers Things that hold other things labels Oct 6, 2021
@kevingranade kevingranade merged commit 127a8d0 into CleverRaven:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double the size of toolboxes
3 participants