Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Military Pilot profession clothes. #52127

Merged
merged 19 commits into from
Oct 12, 2021

Conversation

faefux
Copy link
Contributor

@faefux faefux commented Oct 5, 2021

Summary

Content "Added flight suit and helmet to profession."

Purpose of change

I forgot to add it when they were put in, only just noticed when I went to play the profession.

Describe the solution

Changed the relevant block in json/professions.json. Adding the more realistic uniform.
I also decided to add the more realistic, researhced load out as i already had it for an NPC.
Note: I didn't add the NV goggles or Knife as it's a powerful starting item, feel free to change my mind on either or inform me if you would rather have these items but at a higher points cost.

Edit: I also added the flight suit items in to a couple if itemgroups.

Describe alternatives you've considered

Testing

Made a new character in the profession. Works fine

Additional context

image

@Maleclypse Maleclypse added Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Spawn Creatures, items, vehicles, locations appearing on map labels Oct 6, 2021
@Zireael07
Copy link
Contributor

You'll probably have to redo this PR as you have unrelated changes in (skulls?)

@faefux
Copy link
Contributor Author

faefux commented Oct 11, 2021

You'll probably have to redo this PR as you have unrelated changes in (skulls?)

Thanks, as usual, @Zireael07. Can you show me exactly what you're refering to? I'm a bit confused I think.

@Zireael07
Copy link
Contributor

The first two commits in the commit list that GitHub shows you above my comment (or when you click the commits tab).

The easiest way would be to create a new branch off master (a new fork) and close and delete this one. (There are other ways but they're more involved and well, sometimes they don't work especially here where you have many commits after the problematic ones)

@faefux
Copy link
Contributor Author

faefux commented Oct 11, 2021

I'm just going to leave it I think. If someone else wants to do it then cool, otherwise meh, it's not interesting enough to fuck around with github for the millionth time for.

@ZhilkinSerg ZhilkinSerg merged commit fb79bab into CleverRaven:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants