Use ellipsis character consistently #52128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qrox
reviewed
Oct 6, 2021
Makes every instance of "…" the same, no spaces before, only one space after and this character does not end a sentence
Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>
casswedson
force-pushed
the
typo-smash
branch
from
5016aec to
4069f5a
Compare
casswedson
force-pushed
the
typo-smash
branch
from
adc5762 to
1ce6161
Compare
|
Ellipsis and a full stop? Is that correct grammar-wise? |
|
I think you can use it that way and remains correct https://www.grammarly.com/blog/ellipsis/ |
casswedson
added a commit
to casswedson/Cataclysm-DDA
that referenced
this pull request
Oct 20, 2021
Makes every instance of "…" the same, no spaces before, only one space after and this character does not end a sentence. src folder edition forgot there are a ton of strings in the src folder. Continuation of CleverRaven#52128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Makes every instance of "…" the same, no spaces before, only one space
after and this character does not end a sentence
As to why I chose this arbitrary rules, they are the most common in the current data
Also add a bit of documentation.
Describe the solution
Describe alternatives you've considered
Testing
Additional context