Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Smelly" and "Weak Scent" now are conflicting mutations #52152

Merged
merged 4 commits into from
Oct 7, 2021
Merged

"Smelly" and "Weak Scent" now are conflicting mutations #52152

merged 4 commits into from
Oct 7, 2021

Conversation

anoobindisguise
Copy link
Contributor

@anoobindisguise anoobindisguise commented Oct 7, 2021

Summary

None

Purpose of change

Make Weak Scent and Smelly mutations conflict with each other so that you can no longer both have a Weak Scent and be Smelly.

Describe the solution

SMELLY2 ("Smelly") lacked the SCENT tag, which all other mutations affecting scent had. This resolves the issue by adding direct mutation conflicts to SMELLY2 and WEAKSCENT, because adding the SCENT tag to Smelly would make it conflict with Pheromone mutations.

Describe alternatives you've considered

Add SCENT tag to SMELLY2. This works but makes Pheromone mutations remove SMELLY2 and it appears to be intentional that you both smell terrible and have pheromones, the awful smell is a prerequisite for the more useful mutation.

Testing

Inject alpha serums to a character who has the Smelly mutation, watch Smelly mutation disappear.

Additional context

@TealcOneill
Copy link
Contributor

You forgot the pr part of the pr

@anoobindisguise
Copy link
Contributor Author

You forgot the pr part of the pr

I thought no one would notice if I fixed it fast enough lol. But nope, you guys are insanely fast, serves me right for making a mistake like that.

@TealcOneill
Copy link
Contributor

You don't select a category, you need to do the category followed by a sentence or just 'none' as the line. I would suggest you do none for a small fix like this.

@Maleclypse Maleclypse added <Bugfix> This is a fix for a bug (or closes open issue) Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Oct 7, 2021
@kevingranade kevingranade merged commit 644c2ec into CleverRaven:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants