View offset is not saved while driving #52205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "View offset is not saved while driving"
Purpose of change
Fixes #52136
The view offset would not be saved while driving, and on reloading a save the view offset would be centered incorrectly.
Describe the solution
Added save and load for the player's view offset.
Describe alternatives you've considered
Testing
Tested while driving a vehicle at 32 kph and saving and then loading.
Before: Offset is centered on player on reload. Stopping of the vehicle leaves the view offset in the wrong position. Press of the : key resets the view offset to the correct position on the player.
After: Offset correctly accounts for the vehicle speed on reload. On stopping the vehicle the offset is adjusted to the player. Press of : key has no effect because the offset has been handled correctly and is already centered on the player.
Additional context