Hacksaw bar cutting #52341
Merged
Hacksaw bar cutting #52341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettDong
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Tweaks to hacksaw and torch cutting"
Purpose of change
Fixes #52176. In addition to hacksaws not working on window frames with metal bars, acetylene torches also didn't work for the same reason (missing JSON). Cutting bars off of shop-style windows that DON'T have an alarm made the glass vanish as well. In addition, Sacchi indicated in Discord that they hadn't intended for acetylene torch fuel consumption to be affected by player speed and that swapping to time instead of speed would make more sense.
Describe the solution
Add the JSON for cutting t_window_bars_noglass, modify JSON for cutting t_window_bars, change the JSON for the player action of cutting with the acetylene torch.
Describe alternatives you've considered
If removing the glass on non-alarmed windows when cutting the bars of was desired, adding the glass to the byproducts left over would make sense.
Testing
Load into the game with the modified JSON files, spawn the terrain tiles in question and cut the bars off with hacksaw and torch to verify results. Check that cutting bars with the acetylene torch no longer uses more fuel if the player speed is lowered (used being overencumbered to lower speed).
Additional context