Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructional books are now manuals #53852

Merged
merged 7 commits into from
Dec 30, 2021

Conversation

bombasticSlacks
Copy link
Contributor

@bombasticSlacks bombasticSlacks commented Dec 29, 2021

Summary

Content "Instructional books are now manuals"

Purpose of change

Instructional books being sorted with entertainment novels can be frustrating. Bookstores and libraries can be frustrating. With that said I've split books with recipes, that you can train with and learn martial arts from to a separate category Manuals.

Describe the solution

  • Added Manuals Category
  • Added Manuals Loot Zone
  • Added the category to all relevant books (they are in a lot of separate files I'm so sorry)
  • Added the category to all mod books (again I'm sorry this prompted 5 code reviews)
  • Fixed semi unrelated tests with NPCs that this broke

Describe alternatives you've considered

Maybe I should have done this the other way and changed the category of base books

Testing

Spawn in,

Spawn some books
Check some books
Check some sort zones
(I also tested the e-ink still works)

Additional context

image

image

@Maleclypse Maleclypse added <Enhancement / Feature> New features, or enhancements on existing Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones labels Dec 29, 2021
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Dec 29, 2021
@mkrutov
Copy link
Contributor

mkrutov commented Dec 29, 2021

mind also updating in-repo mods for this change? :)

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Dec 29, 2021
@kevingranade
Copy link
Member

See

CHECK( d.responses[5].text == "This is a u_has_item_category books test response." );

Your category change broke some test preconditions.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 30, 2021
@kevingranade kevingranade merged commit a6b93f3 into CleverRaven:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants