-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved dialog companion mission UI #55746
improved dialog companion mission UI #55746
Conversation
…into tacoma_companion_mission
"LGTM analysis: C/C++": "Failed" by tripping over its own feet by timing out. |
As usual. It always times out for some reason, so it can not really be used to judge PRs at this time except when it reports new or fixed alerts. |
Yes, but unfortunately, it seems that those in power ignore PRs that don't make it through the minefield of broken tests, which is something like 80% of the time. |
I'm pretty much completely overwhelmed by the PR review workload right now. I'm keeping up as best as I can (and sidelining the things I want to work on), but my time is limited at the moment. |
Summary
None
Purpose of change
Describe the solution
Some UI string changes, keep track of whether companions are ready to be returned and indicate that in the UI.
Move the random time factor for companions joining a caravan to the caravan level rather than the individual level, resulting in the check for the companions having the same timers actually working.
Describe alternatives you've considered
Leave if for someone else, but I said I'd do it...
Testing
Using a bunch of conveniently retained saves to verify that the changes actually worked as intended, with the greying out of an entry if no companions are available for return and priority marking (yellow) if any of them is available. Checked that the caravan change had two companions sent off on a caravan together return together when one of them was returned.
Additional context