Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hellfire Stew #55943

Merged
merged 7 commits into from
Mar 20, 2022
Merged

Hellfire Stew #55943

merged 7 commits into from
Mar 20, 2022

Conversation

Maleclypse
Copy link
Member

Summary

None

Purpose of change

Adds Hellfire stew and the recipe to make it. Hellfire Stew was made by soldiers during the Civil War. Also adjusts hardtack fun to the negative since hardtack really requires at minimum some kind of liquid to make it edible.

Describe the solution

Adds recipe for Hellfire Stew using an old civil war recipe. I made it autolearned because if you have hardtack you'll figure out things to do with it pretty quickly.

Describe alternatives you've considered

none

Testing

tbd

Additional context

@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Mar 8, 2022
@Maleclypse Maleclypse added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks labels Mar 8, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 8, 2022
@Inglonias
Copy link
Contributor

Inglonias commented Mar 8, 2022

I know exactly who to blame for you suddenly knowing this recipe.

Co-authored-by: AtomicFox556 <98733651+AtomicFox556@users.noreply.github.com>
Copy link
Member

@NetSysFire NetSysFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this may be out of scope, but https://www.washingtonpost.com/wp-dyn/articles/A46037-2004Dec8.html also mentions a "pudding" utilizing hard tack, would that be reasonable to add, too?

Also I wonder if hard tack should give you the disgusting rations debuff, too.

data/json/items/comestibles/bread.json Show resolved Hide resolved
@Maleclypse Maleclypse marked this pull request as draft March 8, 2022 22:27
@Maleclypse
Copy link
Member Author

I know this may be out of scope, but https://www.washingtonpost.com/wp-dyn/articles/A46037-2004Dec8.html also mentions a "pudding" utilizing hard tack, would that be reasonable to add, too?

Also I wonder if hard tack should give you the disgusting rations debuff, too.

I've moved this to draft to see about some of the options you suggest.

@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Mar 9, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • An old recipe from the American Civil War. First you crush your hardtack into flour with whatever object you have at hand then combine it with the water and regular flour to make a dough. You're going to want to knead in the dried fruits. Boil up your dough into pbread pudding chunks. Finally you add the sweetener. Soldiers would call this a dessert.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 9, 2022
@NetSysFire
Copy link
Member

I found another recipe with hardtack in it: https://en.wikipedia.org/wiki/Fish_and_brewis

@Maleclypse
Copy link
Member Author

I found another recipe with hardtack in it: https://en.wikipedia.org/wiki/Fish_and_brewis

Hmm I could probably make that as a transform since that's an overnight recipe?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 9, 2022
@schoolcf
Copy link
Contributor

how come the description for this is "here's how to cook it" while the description for everything else is "this is what it is"

@Maleclypse
Copy link
Member Author

how come the description for this is "here's how to cook it" while the description for everything else is "this is what it is"

I decided to try something different since these are essentially ad hoc recipes to make an unpalatable foodstuff, palatable. If you read the instructions they do in fact describe what it is, but I personally felt that saying "Hardtack made into a bread pudding", was incredibly short and gave you the reader no clue about what hardtack made into a bread pudding would be like.

@Maleclypse Maleclypse marked this pull request as ready for review March 11, 2022 15:58
@Maleclypse
Copy link
Member Author

I found another recipe with hardtack in it: https://en.wikipedia.org/wiki/Fish_and_brewis

I've decided not to try and make the transform items on this, but I think it would be neat if someone else did. I've basically expended all the mental energy I have on hardtack for the moment, lol.

@kevingranade
Copy link
Member

Your json seems to be crashing the tests.

@Maleclypse
Copy link
Member Author

Your json seems to be crashing the tests.

Yep, I was confused because I thought it was a copy-from test failure but I had no copy-from in this but then reread after your note and saw it was a default value issue. Fixed now.

@ZhilkinSerg ZhilkinSerg merged commit 178dbc8 into CleverRaven:master Mar 20, 2022
@Maleclypse Maleclypse deleted the Hellfire-Stew branch July 18, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants