Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <u_name> and <npc_name> to tag parsing. Update docs for others #56066

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

haveric
Copy link
Contributor

@haveric haveric commented Mar 13, 2022

Summary

Infrastructure "Add <u_name> and <npc_name> to tag parsing"

Purpose of change

Allow names to be used in conversations. Needed for #55690
Also updates the docs to match existing tags

Describe the solution

Adds two new tags that can be used in dialogue that represent the player and npc names

Describe alternatives you've considered

Rename the tags to something else, but this is somewhat consistent with the others. (Some use npc, some use my)

Testing

Tested with my other work for #55690

Additional context

Example usage: { "u_message": "<npc_name> sets a shot and a token on the counter…", "type": "good", "popup": true }

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 13, 2022
@haveric haveric mentioned this pull request Mar 13, 2022
71 tasks
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 13, 2022
@ZhilkinSerg ZhilkinSerg merged commit 694afa1 into CleverRaven:master Mar 16, 2022
@haveric haveric deleted the name-parse-tag branch March 16, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants