Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix farm greenhouse floors. Add metal floors to grain bins. #56124

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

haveric
Copy link
Contributor

@haveric haveric commented Mar 15, 2022

Summary

Bugfixes "Fix farm greenhouse floors. Add metal floors to grain bins."

Purpose of change

The grain bins/silos should have a metal floor/concrete instead of dirt (I chose metal floor to be consistent with other silos currently, although there probably should be concrete silo variants).

Farm greenhouses didn't get floor set for some tiles, which causes columns to sometimes spawn there and roof tiles to not exist (although roofs on the farm variants still suck and I don't have a good way to fix that as I couldn't easily override a roof location with the multiple variants)

Describe the solution

Define better floors

Describe alternatives you've considered

None

Testing

Loaded up a new world and spawned in the farm specials. Saw correct floors.

Additional context

None

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 15, 2022
@Maleclypse Maleclypse added Map / Mapgen Overmap, Mapgen, Map extras, Map display <Bugfix> This is a fix for a bug (or closes open issue) labels Mar 15, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 16, 2022
@ZhilkinSerg ZhilkinSerg merged commit 8f8fcae into CleverRaven:master Mar 16, 2022
@haveric haveric deleted the silo-floor branch March 16, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants