Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tacoma - Doctor improvements #57387

Merged
merged 9 commits into from
May 6, 2022
Merged

Conversation

haveric
Copy link
Contributor

@haveric haveric commented May 3, 2022

Summary

Content "Tacoma - Doctor improvements"

Purpose of change

  • Completes the move of first aid from the nurse to the doctor
  • Add some quests to the doctor
  • Gate bionic installation/removal behind quests
  • Add spawns for crutches since they don't have any (needed for a quest)

Describe the solution

  • Adds new quests and updates dialog for the doctor
  • Multipart quest to gate bionics behind
    • Acquire 3000 units of anesthetic
    • Talk to scavengers to send a companion mission to raid a hospital to get parts for an anesthetic machine / medical equipment
    • Talk to scrappers for metal parts (which will send you on a quest for an angle grinder and a hacksaw)
  • Make scrapper subquest an actual quest
  • Another round of testing for safe measures

Describe alternatives you've considered

None

Testing

Load a save after the doctor has spawned. Run through all of the doctor's quests successfully multiple times.

Additional context

None

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Missions Quests and missions Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels May 3, 2022
@haveric haveric mentioned this pull request May 3, 2022
71 tasks
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 3, 2022
@PatrikLundell
Copy link
Contributor

I don't think the "Mods" tag is correct, as this is standard contents, so I don't know where the bot got that from.

@haveric
Copy link
Contributor Author

haveric commented May 4, 2022

I don't think the "Mods" tag is correct, as this is standard contents, so I don't know where the bot got that from.

It's because I modified the "mods/alt_map_key/overmap_terrain.json" to add the looted_hospital, so I'd say it is technically correct.

@haveric haveric marked this pull request as ready for review May 5, 2022 03:38
@dseguin dseguin merged commit 5363e66 into CleverRaven:master May 6, 2022
@haveric haveric deleted the tacoma-doctor branch May 6, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Missions Quests and missions Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants