Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify option descriptions #57715

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

Faalagorn
Copy link
Contributor

Summary

None

Purpose of change

Unifty descriptions of options.

Describe the solution

  • Always use "If true, " first for the options that are "true"/"false".
  • Use 0 = disabled consistently.
  • Enforce double spaces (mostly in Android options).
  • Use double space between . and - between option values.
  • Make sure all options end with a full stop.
  • Fix minor issues.

Describe alternatives you've considered

  • Use "If false, " for the options that are "true" by default.
  • Don't use double space between . and - between option values.
  • Don't use double spaces for Android.
  • Recheck everything one more time (there's probably still something to fix).

Testing

It's all just the text changes, so hopefully should work fine. Maybe I'll test it deeper tomorrow.

Additional context

Should fix a few Transifex issues if merged.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 15, 2022
@kevingranade kevingranade merged commit b0d3624 into CleverRaven:master May 19, 2022
@Faalagorn Faalagorn deleted the patch-4 branch May 20, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants