Remove x86 specific macro definitions in MSVC build in CMake #62602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Code: Build
github-actions
bot
added
the
BasicBuildPassed
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
An x86-specific macro (either
_X86_or_AMD64_) is defined in CMake if building with MSVC, regardless if target architecture is x86. This is causing problems when building for ARM64: #62594 (comment)Describe the solution
Remove the x86-specific macro definition in CMake.
Describe alternatives you've considered
Testing
Haven't tried cross-compiling to ARM64, but at least the project can still be successfully built on 64-bit x86 Windows.
Additional context
It was added in #13896 to fix some problem back then, but for now I don't see why it's necessary in CMake for MSVC.